fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd
#588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a839bf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/fix-mcms-make-proposal-context-provider-required
branch
from
7ff9767 to
69a000e
Compare
gustavogama-cll
force-pushed
the
ggama/fix-mcms-make-proposal-context-provider-required
branch
from
69a000e to
a839bf7
Compare
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the proposalContextProvider parameter mandatory in the BuildMCMSv2Cmd function by adding validation checks and removing conditional logic.
- Added panic checks for nil
lggrandproposalContextProviderparameters - Removed conditional block that allowed
proposalContextProviderto be nil - Simplified code by directly assigning environment and proposal context to config fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| engine/cld/legacy/cli/mcmsv2/mcms_v2.go | Added nil checks for required parameters and removed conditional logic for optional proposal context provider |
| .changeset/fruity-kings-cross.md | Added changeset documenting the API change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ecPablo
approved these changes
Nov 25, 2025
gustavogama-cll
deleted the
ggama/fix-mcms-make-proposal-context-provider-required
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#588](#588) [`d1febae`](d1febae) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd - [#595](#595) [`95f96d9`](95f96d9) Thanks [@finleydecker](https://github.com/finleydecker)! - Added -eth flag to the evm nodes fund command. Example: users can now use "-eth 10" to fund nodes up to 10 eth. Also added a new line separator to the current balance log to improve readability. - [#594](#594) [`5936b3b`](5936b3b) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): improve error handling in confirmTransaction --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.